feat(tantivy): Phase 2 feature parity with Orama #2801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add field boosting: title field now has 3x boost using BoostQuery - Improve fuzzy search quality: restructured to require all terms (Must) while keeping per-field subclauses as Should - Add doc_type filtering: SearchFilters now supports doc_type filter - Add Count collector: SearchResult now includes total hit count Co-Authored-By: yujonglee <[email protected]>
Co-Authored-By: yujonglee <[email protected]>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
✅ Deploy Preview for hyprnote-storybook canceled.
|
✅ Deploy Preview for hyprnote canceled.
|
✅ Deploy Preview for howto-fix-macos-audio-selection canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(tantivy): Phase 2 feature parity with Orama
Summary
This PR implements Phase 2 feature parity improvements for the tantivy search plugin:
BoostQueryto match Orama'stitle:3, content:1behaviordoc_typefilter toSearchFiltersusingTermQuerySearchResultnow includes total hit count using tuple collector(TopDocs, Count)Review & Testing Checklist for Human
doc_typevalues and verify filtering works correctlycountfield returns the total number of matching documents, not just the number of returned hits (which is limited byrequest.limit)SearchResultnow requirescountfield - verify any code consuming this API handles the new fieldNotes
The
TITLE_BOOSTvalue of 3.0 is hardcoded to match Orama's behavior. If configurability is needed, this could be exposed as a search option in a future PR.Link to Devin run: https://app.devin.ai/sessions/57e748ed9bda4cfba78dc1512c56d51f
Requested by: yujonglee (@yujonglee)